proper use filter in getTags function

[carolhmj]

Fix #14424

[bjsplat]

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

[sebavan]

LGTM, let see what @deltakosh thinks and I hope it was a bug and not intended :-)

[bjsplat]

Snapshot stored with reference name:
refs/pull/14427/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14427/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14427/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/14427/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/14427/merge
https://gui.babylonjs.com/?snapshot=refs/pull/14427/merge
https://nme.babylonjs.com/?snapshot=refs/pull/14427/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/14427/merge#BCU1XR#0

[deltakosh]

I did not write that code but I remember it :)
The story was that the forEach was initially meant to run a piece of code on each selected item. The doc was added later on and was misleading. That being said, I prefer this new version but we need to flag it as breaking change (even if it will probably be minimal)

[carolhmj]

Since we're adding as a breaking change anyway, I'm renaming forEach to filter to make its function clearer 🙂

[RaananW]

Since we're adding as a breaking change anyway, I'm renaming forEach to filter to make its function clearer 🙂

Changing the name of a variable is not a really breaking change. it doesn't change a thing when calling the function.

[AlexanderMelde]

Do I understand correctly, the migration of the breaking change is simply the following?
scene.getMeshesByTags(tag, fn); -> scene.getMeshesByTags(tag).map(fn);

[sebavan]

Sorry for the misunderstanding here.

Yes to have same behavior you could do scene.getMeshesByTags(tag, fn); -> scene.getMeshesByTags(tag).forEach(fn); as fn is now really use as a predicate like it was intended before.