Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

add FlowGraphEngine class #14350

Merged
merged 6 commits into from Sep 27, 2023
Merged

add FlowGraphEngine class #14350

merged 6 commits into from Sep 27, 2023

Conversation

carolhmj
Copy link
Contributor

@sebavan I think you were waiting for this one 馃槈

Small change, but it will be useful in situations where we create more than one graph. The engine currently holds a list of graphs and a common event coordinator for all those graphs.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2023

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14350/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2023

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14350/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 26, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14350/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 26, 2023

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14350/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@RaananW RaananW merged commit ef1e1e7 into BabylonJS:master Sep 27, 2023
10 checks passed
@carolhmj carolhmj deleted the flowGraphEngine branch October 3, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants