Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to styling of NME and NGE #14349

Merged
merged 2 commits into from Sep 25, 2023
Merged

Fix to styling of NME and NGE #14349

merged 2 commits into from Sep 25, 2023

Conversation

carolhmj
Copy link
Contributor

Trying to separate the class names more so one doesn't contaminate the other
Fix #14347
Fix #14348

@carolhmj carolhmj added bug nme Node Material Editor nge labels Sep 25, 2023
@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2023

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14349/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2023

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14349/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

1 similar comment
@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2023

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14349/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14349/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@sebavan sebavan merged commit b3d318a into BabylonJS:master Sep 25, 2023
10 checks passed
@carolhmj carolhmj deleted the fix-nme-nge branch October 3, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug nge nme Node Material Editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible to drop a category to NME/NGE UI colors for NGE leaking to NME
4 participants