Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add coordinate transform and constant value blocks #14333

Merged
merged 8 commits into from Sep 27, 2023

Conversation

carolhmj
Copy link
Contributor

Changes:

Examples:

Transform a point from box1's space to box2's space: #EMA2AF

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 21, 2023

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 21, 2023

Copy link
Member

@sebavan sebavan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly the GC comment and creating an issue to track down the missing nodes and good to go

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2023

Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14333/merge/testResults/webgl1/index.html

If tests were successful afterwards, this report might not be available anymore.

@bjsplat
Copy link
Collaborator

bjsplat commented Sep 25, 2023

Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14333/merge/testResults/webgl2/index.html

If tests were successful afterwards, this report might not be available anymore.

@sebavan
Copy link
Member

sebavan commented Sep 27, 2023

Small one @carolhmj
image

@sebavan sebavan merged commit 683275a into BabylonJS:master Sep 27, 2023
10 checks passed
@carolhmj carolhmj deleted the flowGraphCoordTransformBlock branch October 3, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants