New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coordinate transform and constant value blocks #14333
Add coordinate transform and constant value blocks #14333
Conversation
Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s). |
packages/dev/core/src/FlowGraph/Blocks/Data/flowGraphCoordinateTransformBlock.ts
Show resolved
Hide resolved
Snapshot stored with reference name: Test environment: To test a playground add it to the URL, for example: https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14333/merge/index.html#WGZLGJ#4600 Links to test babylon tools with this snapshot: https://playground.babylonjs.com/?snapshot=refs/pull/14333/merge To test the snapshot in the playground with a playground ID add it after the snapshot query string: https://playground.babylonjs.com/?snapshot=refs/pull/14333/merge#BCU1XR#0 |
packages/dev/core/src/FlowGraph/Blocks/Data/flowGraphCoordinateTransformBlock.ts
Show resolved
Hide resolved
packages/dev/core/src/FlowGraph/Blocks/Data/flowGraphCoordinateTransformBlock.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mostly the GC comment and creating an issue to track down the missing nodes and good to go
Visualization tests for webgl1 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
Visualization tests for webgl2 have failed. If some tests failed because the snapshots do not match, the report can be found at If tests were successful afterwards, this report might not be available anymore. |
packages/dev/core/src/FlowGraph/Blocks/Data/flowGraphCoordinateTransformBlock.ts
Outdated
Show resolved
Hide resolved
Small one @carolhmj |
Changes:
Examples:
Transform a point from box1's space to box2's space: #EMA2AF