Merge pull request #14467 from sebavan/rotatefix

Fix transform node world space rotation when parent has negative world matrix determinant
BabylonJS · Oct 26, 2023 · f559ef9 · f559ef9
2 parents 381a602 + efa3e35
commit f559ef9
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/packages/dev/core/src/Meshes/transformNode.ts b/packages/dev/core/src/Meshes/transformNode.ts
@@ -906,9 +906,14 @@ export class TransformNode extends Node {
             this.rotationQuaternion.multiplyToRef(rotationQuaternion, this.rotationQuaternion);
         } else {
             if (this.parent) {
+                const parentWorldMatrix = this.parent.getWorldMatrix();
                 const invertParentWorldMatrix = TmpVectors.Matrix[0];
-                this.parent.getWorldMatrix().invertToRef(invertParentWorldMatrix);
+                parentWorldMatrix.invertToRef(invertParentWorldMatrix);
                 axis = Vector3.TransformNormal(axis, invertParentWorldMatrix);
+
+                if (parentWorldMatrix.determinant() < 0) {
+                    amount *= -1;
+                }
             }
             rotationQuaternion = Quaternion.RotationAxisToRef(axis, amount, TransformNode._RotationAxisCache);
             rotationQuaternion.multiplyToRef(this.rotationQuaternion, this.rotationQuaternion);