Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pod identity #795

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Support pod identity #795

merged 1 commit into from
Mar 11, 2025

Conversation

rayluo
Copy link
Collaborator

@rayluo rayluo commented Mar 7, 2025

This PR resolves #794

The test automation currently fails due to an irrelevant issue (Ciam CUD lab seems to be down). This does not block this PR from being reviewed.

@rayluo rayluo requested a review from a team as a code owner March 7, 2025 03:01
@rayluo rayluo merged commit 689e862 into dev Mar 11, 2025
18 checks passed
@rayluo rayluo deleted the pod-identity branch March 11, 2025 00:44
@rayluo rayluo mentioned this pull request Mar 11, 2025
@jiasli
Copy link
Contributor

jiasli commented Mar 21, 2025

This PR also brought back #754 which got reverted by #769.

@rayluo
Copy link
Collaborator Author

rayluo commented Mar 21, 2025

This PR also brought back #754 which got reverted by #769.

Kind of. I even mentioned that in #754.

There is no problem here. #754 was reverted for other consideration, #795 is implemented because it has a justifiable need. The fact that #754 can be achieved via #795 is an acceptable coincidence.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Msal does not honor environment variable AZURE_POD_IDENTITY_AUTHORITY_HOST in IMDS
4 participants