Pass Sku and Ver to MsalRuntime #786
Merged
+18
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayluo
reviewed
Feb 6, 2025
rayluo
reviewed
Feb 6, 2025
rayluo
reviewed
Feb 6, 2025
msal/broker.py
Outdated
| @@ -7,8 +7,12 @@ | |||
| import time | |||
| import uuid | |||
|
|
|||
| from .application import __version__ | |||
There was a problem hiding this comment.
Better add a new sku.py which contains nothing but SKU="..." and __version__ = "...", and then we have both application.py and broker.py (plus __init__.py) do from .sku import .... This way, the application.py and broker.py will not have a circular reference to each other.
rayluo
approved these changes
Feb 7, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes Msal.py sku and version to Msalcpp during runtime flows to be used in x-client-xtra-sku header in order to support ESTS telemetry
AB#3138694