Fix document for using SystemAssigned managed identity
#764
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiasli
commented
Nov 1, 2024
| @@ -223,7 +223,7 @@ def __init__( | |||
| you may use an environment variable (such as MY_MANAGED_IDENTITY_CONFIG) | |||
| to store a json blob like | |||
| ``{"ManagedIdentityIdType": "ClientId", "Id": "foo"}`` or | |||
| ``{"ManagedIdentityIdType": "SystemAssignedManagedIdentity", "Id": null})``. | |||
| ``{"ManagedIdentityIdType": "SystemAssigned", "Id": null}``. | |||
There was a problem hiding this comment.
The detection logic is to compare ManagedIdentityIdType's value with "SystemAssigned":
Using "SystemAssignedManagedIdentity" will trigger error:
microsoft-authentication-library-for-python/msal/managed_identity.py
Lines 239 to 240 in 6e58a3f
jiasli
commented
Nov 1, 2024
| @@ -223,7 +223,7 @@ def __init__( | |||
| you may use an environment variable (such as MY_MANAGED_IDENTITY_CONFIG) | |||
| to store a json blob like | |||
| ``{"ManagedIdentityIdType": "ClientId", "Id": "foo"}`` or | |||
| ``{"ManagedIdentityIdType": "SystemAssignedManagedIdentity", "Id": null})``. | |||
There was a problem hiding this comment.
The ) symbol is not needed.
rayluo
approved these changes
Nov 2, 2024
rayluo
force-pushed
the
SystemAssigned
branch
from
6e58a3f to
ac7806d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.