Refactor to allow adding new field into cache key and/or content #751
+93
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayluo
force-pushed
the
flexible-cache
branch
from
88cf020 to
e5974b3
Compare
rayluo
force-pushed
the
flexible-cache
branch
from
e5974b3 to
a5a459f
Compare
rayluo
force-pushed
the
flexible-cache
branch
from
a5a459f to
60144d5
Compare
rayluo
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the token cache was based on an internal schema. Over the years, we have hardly changed the token's value to store new fields, and we never changed the token's key format for fear of potential token cache miss.
This PR refactors the token cache implementation. After this PR, future addition of new fields will be as simple as two steps:
This PR is a pure refactoring which does NOT actually change the token key behavior.