Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JsonWebToken properties were throwing when string was 'null' #2335

Merged
merged 1 commit into from Sep 28, 2023
Merged

JsonWebToken properties were throwing when string was 'null' #2335

merged 1 commit into from Sep 28, 2023

Conversation

brentschmaltz
Copy link
Member

Fix null ref when strings were null.
Fixed miscount when formatting error on payload.

sruke
sruke approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@sruke sruke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Added a minor suggestion.

fixed null ref, claim as string was null
694f992 
fixed miscount when formating error on payload
@brentschmaltz brentschmaltz merged commit 70c30b4 into dev Sep 28, 2023
5 checks passed
@brentschmaltz brentschmaltz deleted the brentsch/IssuerNull branch September 28, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sruke sruke sruke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brentschmaltz @sruke