Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Action to use Node.js v20 #411

Merged
merged 3 commits into from Feb 20, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions .github/workflows/azure-login-negative.yml
Expand Up @@ -21,10 +21,10 @@ jobs:
- name: 'Checking out repo code'
uses: actions/checkout@v4

- name: Set Node.js 16.x for GitHub Action
- name: Set Node.js 20.x for GitHub Action
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x

- name: 'Validate build'
run: |
Expand Down Expand Up @@ -84,10 +84,10 @@ jobs:
- name: 'Checking out repo code'
uses: actions/checkout@v4

- name: Set Node.js 16.x for GitHub Action
- name: Set Node.js 20.x for GitHub Action
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x

- name: 'Validate build'
run: |
Expand Down Expand Up @@ -345,10 +345,10 @@ jobs:
- name: 'Checking out repo code'
uses: actions/checkout@v4

- name: Set Node.js 16.x for GitHub Action
- name: Set Node.js 20.x for GitHub Action
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x

- name: 'Validate build'
run: |
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/azure-login-positive.yml
Expand Up @@ -20,10 +20,10 @@ jobs:
- name: 'Checking out repo code'
uses: actions/checkout@v4

- name: Set Node.js 16.x for GitHub Action
- name: Set Node.js 20.x for GitHub Action
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x

- name: 'Validate build'
run: |
Expand Down Expand Up @@ -116,10 +116,10 @@ jobs:
- name: 'Checking out repo code'
uses: actions/checkout@v4

- name: Set Node.js 16.x for GitHub Action
- name: Set Node.js 20.x for GitHub Action
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x

- name: 'Validate build'
run: |
Expand Down Expand Up @@ -256,10 +256,10 @@ jobs:
- name: 'Checking out repo code'
uses: actions/checkout@v4

- name: Set Node.js 16.x for GitHub Action
- name: Set Node.js 20.x for GitHub Action
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x

- name: 'Validate build'
run: |
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/azure-login-pr-check.yml
Expand Up @@ -16,11 +16,11 @@ jobs:
repository: ${{ github.event.pull_request.head.repo.full_name }}
ref: ${{ github.event.pull_request.head.ref }}

# Using 16.x version as an example
- name: Set Node.js 16.x for GitHub Action
# Using 20.x version as an example
- name: Set Node.js 20.x for GitHub Action
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x

- name: installing node_modules
run: npm install
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Expand Up @@ -20,16 +20,16 @@ jobs:
- name: 'Checking out repo code'
uses: actions/checkout@v4

- name: Set Node.js 16.x for GitHub Action
- name: Set Node.js 20.x for GitHub Action
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x

- name: 'Validate build'
run: |
npm install
npm run build

- name: 'Run L0 tests'
run: |
npm run test
2 changes: 1 addition & 1 deletion .github/workflows/markdownlint.yml
Expand Up @@ -11,7 +11,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: 16.x
node-version: 20.x
- name: Run Markdownlint
run: |
npm i -g markdownlint-cli2
Expand Down
10 changes: 5 additions & 5 deletions action.yml
@@ -1,7 +1,7 @@
# Login to Azure subscription
name: 'Azure Login'
description: 'Authenticate to Azure and run your Azure CLI or Azure PowerShell based actions or scripts.'
inputs:
inputs:
creds:
description: 'Paste output of `az ad sp create-for-rbac` as value of secret variable: AZURE_CREDENTIALS'
required: false
Expand All @@ -14,7 +14,7 @@ inputs:
subscription-id:
description: 'Azure subscriptionId'
required: false
enable-AzPSSession:
enable-AzPSSession:
description: 'Set this value to true to enable Azure PowerShell Login in addition to Azure CLI login'
required: false
default: false
Expand All @@ -27,18 +27,18 @@ inputs:
required: false
default: false
audience:
description: 'Provide audience field for access-token. Default value is api://AzureADTokenExchange'
description: 'Provide audience field for access-token. Default value is api://AzureADTokenExchange'
required: false
default: 'api://AzureADTokenExchange'
auth-type:
description: 'The type of authentication. Supported values are SERVICE_PRINCIPAL, IDENTITY. Default value is SERVICE_PRINCIPAL'
description: 'The type of authentication. Supported values are SERVICE_PRINCIPAL, IDENTITY. Default value is SERVICE_PRINCIPAL'
required: false
default: 'SERVICE_PRINCIPAL'
branding:
icon: 'login.svg'
color: 'blue'
runs:
using: 'node16'
using: 'node20'
pre: 'lib/cleanup.js'
main: 'lib/main.js'
post: 'lib/cleanup.js'