Implement continuation token size limit #30600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this adds continuation token size limit tot he python sdk. The new option for item queries accepts an integer value greater than 1 and is represented in terms of KB, ie 2 is 2kb or 2048 Bytes.
bambriz
requested review from
kushagraThapar,
simorenoh,
simplynaveen20,
xinlian12 and
annatisch
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
simorenoh
requested changes
Jun 2, 2023
added samples for using the new feature of limiting continuation token size.
|
Seems like the pipelines are complaining but otherwise LGTM! Let's try to get other reviews so we can release this after the next stable release. |
This should prevent CSpell error for necessary string literal.
Ignore line too long
simorenoh
approved these changes
Jun 7, 2023
simorenoh
reviewed
Jun 7, 2023
Added provisional for the new keyword we are adding with this feature.
kushagraThapar
requested changes
Jun 7, 2023
There was a problem hiding this comment.
There are no tests for this feature.
@bambriz - for every feature we add, we should aim to add tests to make sure we test it and catch future regressions.
For now this test verifies that the continuation token limit size was passed in the request headers.
kushagraThapar
approved these changes
Jun 8, 2023
Co-authored-by: Kushagra Thapar <kushuthapar@gmail.com>
simorenoh
pushed a commit
that referenced
this pull request
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds continuation token size limit support to the python sdk. The new option for item queries accepts a non-negative integer value and is represented in terms of KB, ie 2 is 2kb or 2048 Bytes. This PR fixes issue #27625
sample:
query_iterable = container.query_items(query="SELECT * FROM c where c.some_field = 'some_value'", max_item_count=max_count, partition_key=Some_Partition_Key, response_continuation_token_limit_in_kb=8)This query will limit the continuation token size to 8KB.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines