Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set wiretap if a LoggingHandler exists #39976

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

alzimmermsft
Copy link
Member

Description

Updates NettyAsyncHttpClientBuilder to ignore the wiretap configuration if a Netty LoggingHandler has already been set. wiretap(boolean) that we use sets a very basic LoggingHandler that doesn't have much nuance to it, so blindly setting this does a disservice to anyone who has passed an existing Reactor Netty HttpClient with a configured logger.

This also marks the wiretap API as deprecated with a recommendation to use the Reactor Netty HttpClient builder with a logger configured.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@azure-sdk
Copy link
Collaborator

API change check

APIView has identified API level changes in this PR and created following API reviews.

com.azure:azure-core-http-netty

@alzimmermsft alzimmermsft merged commit df6d3dd into Azure:main Apr 30, 2024
36 checks passed
@alzimmermsft alzimmermsft deleted the AzNetty_ChangeHowWiretapIsSet branch April 30, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure.Core azure-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants