Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary warnings in administration client #37915

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

conniey
Copy link
Member

@conniey conniey commented Dec 4, 2023

Description

  • Removes extraneous log messages when creating subscription or topics. Since support of default rule in subscriptions, it is possible to not see a RuleAction or RuleFilter in the XML. This should not return a WARN.
  • For missing entities, the service can return an entry with no content.

Fixes #32325

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

@conniey conniey changed the title Servicebus/warning subscription Remove unnecessary warnings in administration client Dec 4, 2023
Copy link
Member

@anuchandy anuchandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks lgtm!

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@conniey conniey merged commit 6e86a45 into Azure:main Dec 4, 2023
17 checks passed
@conniey conniey deleted the servicebus/warning-subscription branch April 17, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] A warning message is generated when creating a subscription
3 participants