Fix Edge Case in Query Parameter Parsing #34459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alzimmermsft
added
Client
alzimmermsft
requested review from
srnagar,
anuchandy,
lmolkova,
vcolin7,
mssfang,
JonathanGiles and
billwert
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
alzimmermsft
requested review from
ibrahimrabab and
jaschrep-msft
as code owners
|
/azp run java - core |
|
Azure Pipelines successfully started running 1 pipeline(s). |
billwert
approved these changes
Apr 14, 2023
alzimmermsft
changed the title
srnagar
approved these changes
Apr 14, 2023
...e-storage-common/src/main/java/com/azure/storage/common/implementation/StorageImplUtils.java
Show resolved
Hide resolved
srnagar
reviewed
Apr 14, 2023
...e-storage-common/src/main/java/com/azure/storage/common/implementation/StorageImplUtils.java
Show resolved
Hide resolved
srnagar
reviewed
Apr 14, 2023
| * @param queryParameters The query parameter string. | ||
| * @return An {@link Iterator} over the query parameter key-value pairs. | ||
| */ | ||
| public static Iterator<Map.Entry<String, String>> parseQueryParameters(String queryParameters) { |
There was a problem hiding this comment.
We should return Map<String, String> instead of the iterator and the implementation could be a LinkedHashMap to preserve the order.
There was a problem hiding this comment.
This API would need to change to Map<String, QuertyParameter> or Map<String, List<String>> in this case, the current design is to iterate over all parsed query parameters and let the caller handle using or storing them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an edge case found in query parameter parsing for query parameters with no value, ex
key&key2=value2.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines