Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync eng/common directory with azure-sdk-tools for PR 7615 #22335

Merged
merged 4 commits into from
Feb 2, 2024

Commits on Feb 2, 2024

  1. Prepare-Release.ps1: Make dateTime.ToString("MM/dd/yyyy") to work on …

    …exotic set-ups
    
    On my machine, I experimented with the registry, and the worst part is that I don't remember/know how to reset it back.
    
    The work items that script produces, do have datetimes for the upcoming releases in the `MM-dd-yyyy` format, and then I have to correct them by hand.
    
    `dateTime.ToString("MM/dd/yyyy")` does produce the date in the format of `MM-dd-yyyy` on my machine. This also happens if I write a corresponding .NET app.
    
    The fix that I am proposing makes it work on my specific setup and hopefully breaks no one else. I understand if you are hesitant to take it. Let me know, I'll see how I can restore my setting.
    
    But on the other hand, I don't think it makes anything worse, it only makes things more robust, so maybe take it?
    antkmsft authored and azure-sdk committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    6f4f7ee View commit details
    Browse the repository at this point in the history
  2. Use [CultureInfo]::InvarialtCulture

    Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
    2 people authored and azure-sdk committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    21dfe4d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    91be0d9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e01b880 View commit details
    Browse the repository at this point in the history