Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert win2022 image back to latest and add msvc version mitigation #5539

Merged
merged 25 commits into from
Apr 18, 2024

Conversation

danieljurek
Copy link
Member

No description provided.

@LarryOsterman
Copy link
Member

/azp run cpp - core - ci

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@danieljurek
Copy link
Member Author

/azp run cpp - core

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@danieljurek danieljurek marked this pull request as ready for review April 18, 2024 20:57
@danieljurek danieljurek self-assigned this Apr 18, 2024
@danieljurek danieljurek added the Central-EngSys This issue is owned by the Engineering System team. label Apr 18, 2024
@benbp
Copy link
Member

benbp commented Apr 18, 2024

If this is a temp fix can we add some TODO comments and a follow-up issue so this doesn't stick around in source?

Copy link
Member

@weshaggard weshaggard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this for a temporary fix.

@danieljurek danieljurek enabled auto-merge (squash) April 18, 2024 21:45
@danieljurek danieljurek enabled auto-merge (squash) April 18, 2024 21:46
@danieljurek danieljurek merged commit ad30d10 into main Apr 18, 2024
41 checks passed
@danieljurek danieljurek deleted the djurek/msvc-mitigation branch April 18, 2024 22:11
microzchang added a commit that referenced this pull request Apr 23, 2024
* Sync eng/common directory with azure-sdk-tools for PR 8110 (#5540)

* Show review link in logs and set DevOps project name based on the pipeline run

* Handle the failures when package work item is unassigned (#5551)

Co-authored-by: Praveen Kuttappan <prmarott@microsoft.com>

* Revert win2022 image back to latest and add msvc version mitigation (#5539)

* Revert win2022 image back to latest
* Workaround fix for MSVC SxS issue

* Fix Policheck step indention (#5553)

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

* Sync .github/workflows directory with azure-sdk-tools for PR 8131 (#5555)

* Update to azure/login@v2

* Remove the unnecessary setting of enable-AzPSSession. We don't need it.

---------

Co-authored-by: James Suplizio <jasupliz@microsoft.com>

* Update sorting algorithm used in storage shared-key signing (#5547)

* Remove Windows upgrade of cmake (windows image now uses working version of cmake) (#5558)

* Revert "Update sorting algorithm used in storage shared-key signing (#5547)" (#5560)

This reverts commit b6e04fd.

---------

Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Praveen Kuttappan <prmarott@microsoft.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: James Suplizio <jasupliz@microsoft.com>
Co-authored-by: JinmingHu <jinmhu@microsoft.com>
microzchang added a commit to microzchang/azure-sdk-for-cpp that referenced this pull request May 27, 2024
* Sync eng/common directory with azure-sdk-tools for PR 8110 (Azure#5540)

* Show review link in logs and set DevOps project name based on the pipeline run

* Handle the failures when package work item is unassigned (Azure#5551)

Co-authored-by: Praveen Kuttappan <prmarott@microsoft.com>

* Revert win2022 image back to latest and add msvc version mitigation (Azure#5539)

* Revert win2022 image back to latest
* Workaround fix for MSVC SxS issue

* Fix Policheck step indention (Azure#5553)

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

* Sync .github/workflows directory with azure-sdk-tools for PR 8131 (Azure#5555)

* Update to azure/login@v2

* Remove the unnecessary setting of enable-AzPSSession. We don't need it.

---------

Co-authored-by: James Suplizio <jasupliz@microsoft.com>

* Update sorting algorithm used in storage shared-key signing (Azure#5547)

* Remove Windows upgrade of cmake (windows image now uses working version of cmake) (Azure#5558)

* Revert "Update sorting algorithm used in storage shared-key signing (Azure#5547)" (Azure#5560)

This reverts commit b6e04fd.

---------

Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Praveen Kuttappan <prmarott@microsoft.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: James Suplizio <jasupliz@microsoft.com>
Co-authored-by: JinmingHu <jinmhu@microsoft.com>
microzchang added a commit that referenced this pull request May 28, 2024
* update to stable (#5541)

* Storage/ Merge main to unblock pipeline failure (#5561)

* Sync eng/common directory with azure-sdk-tools for PR 8110 (#5540)

* Show review link in logs and set DevOps project name based on the pipeline run

* Handle the failures when package work item is unassigned (#5551)

Co-authored-by: Praveen Kuttappan <prmarott@microsoft.com>

* Revert win2022 image back to latest and add msvc version mitigation (#5539)

* Revert win2022 image back to latest
* Workaround fix for MSVC SxS issue

* Fix Policheck step indention (#5553)

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>

* Sync .github/workflows directory with azure-sdk-tools for PR 8131 (#5555)

* Update to azure/login@v2

* Remove the unnecessary setting of enable-AzPSSession. We don't need it.

---------

Co-authored-by: James Suplizio <jasupliz@microsoft.com>

* Update sorting algorithm used in storage shared-key signing (#5547)

* Remove Windows upgrade of cmake (windows image now uses working version of cmake) (#5558)

* Revert "Update sorting algorithm used in storage shared-key signing (#5547)" (#5560)

This reverts commit b6e04fd.

---------

Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Praveen Kuttappan <prmarott@microsoft.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: James Suplizio <jasupliz@microsoft.com>
Co-authored-by: JinmingHu <jinmhu@microsoft.com>

* Storage/STG94 Snapshot management support via REST for NFS shares (#5543)

* add nfs support (#5267)

* add test recordinhg

* Storage/STG94 GetAccountInfo() for container and blob (#5550)

* add getaccountinfo

* update record

* Storage/STG94 Add Queues bearer challenge test case (#5556)

* Add test for queue bearer challenge

* update test case

* update var name

* update test case

* fix clang format

* Update sorting algorithm used in storage shared-key signing (#5611)

* Storage/Stg94 Support for authorization ExtendedErrorDetail (#5633)

* Support for authorization ExtendedErrorDetail

* fix clang format

* fix build error

* make tests live only

* Update change log

* remove additional changes

* update changelog

* update error detail liveonly

* Update live test

---------

Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com>
Co-authored-by: Praveen Kuttappan <prmarott@microsoft.com>
Co-authored-by: Daniel Jurek <djurek@microsoft.com>
Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
Co-authored-by: James Suplizio <jasupliz@microsoft.com>
Co-authored-by: JinmingHu <jinmhu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Central-EngSys This issue is owned by the Engineering System team.
Projects
Development

Successfully merging this pull request may close these issues.

None yet

7 participants