Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Blob extension: Infer collection bindings using the blobPath #1690

Merged
merged 16 commits into from
Jul 13, 2023
Merged

Blob extension: Infer collection bindings using the blobPath #1690

merged 16 commits into from
Jul 13, 2023

Conversation

liliankasem
Copy link
Member

@liliankasem liliankasem commented Jun 27, 2023 •
edited

Issue describing the changes in this PR

resolves #1675

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@liliankasem liliankasem changed the base branch from main to feature/sdk-type-binding June 27, 2023 00:17
@liliankasem liliankasem mentioned this pull request Jun 27, 2023
Closed
7 tasks
@liliankasem liliankasem marked this pull request as ready for review June 28, 2023 00:19
@liliankasem liliankasem force-pushed the liliankasem/blob/infer-batch branch 5 times, most recently from d82b674 to 9533c59 Compare June 29, 2023 22:14
@liliankasem liliankasem force-pushed the liliankasem/blob/infer-batch branch 2 times, most recently from b2a42db to 72abdf3 Compare July 7, 2023 23:14
fabiocav
fabiocav reviewed Jul 10, 2023
View reviewed changes
extensions/Worker.Extensions.Storage.Blobs/src/BlobStorageConverter.cs Outdated Show resolved Hide resolved
extensions/Worker.Extensions.Storage.Blobs/src/BlobStorageConverter.cs Outdated Show resolved Hide resolved
extensions/Worker.Extensions.Storage.Blobs/src/BlobStorageConverter.cs Outdated Show resolved Hide resolved
extensions/Worker.Extensions.Storage.Blobs/src/BlobStorageConverter.cs Outdated Show resolved Hide resolved
extensions/Worker.Extensions.Storage.Blobs/src/BlobStorageConverter.cs Outdated Show resolved Hide resolved
extensions/Worker.Extensions.Storage.Blobs/src/BlobStorageConverter.cs Show resolved Hide resolved
extensions/Worker.Extensions.Storage.Blobs/src/BlobStorageConverter.cs Outdated Show resolved Hide resolved
extensions/Worker.Extensions.Storage.Blobs/src/BlobStorageConverter.cs Outdated Show resolved Hide resolved
@liliankasem liliankasem force-pushed the liliankasem/blob/infer-batch branch 2 times, most recently from 6d8a255 to ba77dfc Compare July 11, 2023 16:48
liliankasem pushed a commit that referenced this pull request Jul 12, 2023
@surgupta-msft @liliankasem
Adding BlobContainerClient scenario in analyzer (#1690)
3f6afe3
liliankasem pushed a commit that referenced this pull request Jul 13, 2023
@surgupta-msft @liliankasem
Adding BlobContainerClient scenario in analyzer (#1690)
ac9d8dc
fabiocav
fabiocav approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@fabiocav fabiocav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leaving one comment, but not blocking.

extensions/Worker.Extensions.Storage.Blobs/src/BlobStorageConverter.cs Outdated Show resolved Hide resolved
@liliankasem liliankasem merged commit cf87fb7 into feature/sdk-type-binding Jul 13, 2023
23 checks passed
@liliankasem liliankasem deleted the liliankasem/blob/infer-batch branch July 13, 2023 23:55
liliankasem added a commit that referenced this pull request Jul 14, 2023
@liliankasem
Blob extension: Infer collection bindings using the blobPath (#1690)
9dae4c0
liliankasem added a commit that referenced this pull request Jul 17, 2023
@liliankasem
Infer collection bindings using the blobPath (#1690)
c62ac72
liliankasem added a commit that referenced this pull request Jul 17, 2023
@liliankasem
Infer collection bindings using the blobPath (#1690)
4bd6085
liliankasem pushed a commit that referenced this pull request Jul 17, 2023
@surgupta-msft @liliankasem
Adding BlobContainerClient scenario in analyzer (#1690)
eb710d9
liliankasem added a commit that referenced this pull request Jul 17, 2023
@liliankasem
Infer collection bindings using the blobPath (#1690)
6781c9f
liliankasem added a commit that referenced this pull request Jul 18, 2023
@liliankasem
Infer collection bindings using the blobPath (#1690)
909f03d
liliankasem added a commit that referenced this pull request Jul 18, 2023
@liliankasem
Infer collection bindings using the blobPath (#1690)
0a18b14
liliankasem added a commit that referenced this pull request Jul 18, 2023
@liliankasem
Infer collection bindings using the blobPath (#1690)
960907b
liliankasem added a commit that referenced this pull request Jul 18, 2023
@liliankasem
Infer collection bindings using the blobPath (#1690)
68f9033
liliankasem added a commit that referenced this pull request Jul 19, 2023
@liliankasem
Infer collection bindings using the blobPath (#1690)
11fc07e
liliankasem added a commit that referenced this pull request Jul 19, 2023
@liliankasem
Infer collection bindings using the blobPath (#1690)
d3a1364
liliankasem added a commit that referenced this pull request Jul 19, 2023
@liliankasem
Infer collection bindings using the blobPath (#1690)
10d3113
liliankasem added a commit that referenced this pull request Jul 20, 2023
@liliankasem
Infer collection bindings using the blobPath (#1690)
88bf610
JoshLove-msft pushed a commit to JoshLove-msft/azure-functions-dotnet-worker that referenced this pull request Oct 4, 2023
@liliankasem @JoshLove-msft
Blob extension: Infer collection bindings using the blobPath (Azure#1690
8912293 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabiocav fabiocav fabiocav approved these changes

@jviau jviau jviau approved these changes

@surgupta-msft surgupta-msft surgupta-msft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update worker blob extension to infer IsBatched
4 participants
@liliankasem @fabiocav @jviau @surgupta-msft