Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Source Gen] Cleanup #1453

Merged
merged 5 commits into from
Apr 19, 2023
Merged

[Source Gen] Cleanup #1453

merged 5 commits into from
Apr 19, 2023
+147 −56

Conversation

satvu
Copy link
Member

@satvu satvu commented Apr 5, 2023 •
edited
Loading

Issue describing the changes in this PR

General cleanup following refactoring examples set in #1309

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

Sorry, something went wrong.

satvu added 2 commits April 3, 2023 20:09
@satvu
initial wip cleanup

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
2f12c51
@satvu
refactor to reuse types loaded from compilation

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
387f6e8
@satvu satvu changed the title Satvu/sourcegen cleanup [Source Gen] Cleanup Apr 5, 2023
@satvu
revert generator csproj change

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
GPG key ID: B5690EEEBB952194
Verified
Learn about vigilant mode
fa4badd
@satvu satvu requested a review from jviau April 5, 2023 21:39
@satvu satvu marked this pull request as ready for review April 10, 2023 17:42
jviau
jviau approved these changes Apr 18, 2023
View reviewed changes
@satvu satvu merged commit 4204b01 into main Apr 19, 2023
@satvu satvu deleted the satvu/sourcegen-cleanup branch April 19, 2023 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@surgupta-msft surgupta-msft

@liliankasem liliankasem

@jviau jviau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@satvu @liliankasem @jviau @surgupta-msft