Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sdk-type binding collection reference type #1207

Merged
merged 10 commits into from
Dec 20, 2022
Merged

Support sdk-type binding collection reference type #1207

merged 10 commits into from
Dec 20, 2022

Conversation

surgupta-msft
Copy link
Contributor

@surgupta-msft surgupta-msft commented Dec 1, 2022 •
edited

Issue describing the changes in this PR

Support for collection reference type

Issue - #1156
Parallel to this commit - #1107

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

Additional information

Additional PR information

@surgupta-msft surgupta-msft mentioned this pull request Dec 1, 2022
Closed
2 tasks
@surgupta-msft surgupta-msft marked this pull request as ready for review December 3, 2022 01:16
@surgupta-msft
Copy link
Contributor Author

/check-enforcer evaluate

liliankasem
liliankasem reviewed Dec 5, 2022
View reviewed changes
Copy link
Member

@liliankasem liliankasem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, will sign off once I am able to run this E2E locally

@surgupta-msft
Copy link
Contributor Author

/check-enforcer evaluate

@surgupta-msft surgupta-msft merged commit 07bdacb into main Dec 20, 2022
@surgupta-msft surgupta-msft deleted the sdk-bindings/collection-reference-support branch December 20, 2022 22:28
liliankasem pushed a commit that referenced this pull request Dec 23, 2022
@surgupta-msft @liliankasem
Support sdk-type binding collection reference type (#1207)
4c21927 
* Added collection model binding data support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kshyju kshyju kshyju left review comments

@liliankasem liliankasem liliankasem approved these changes

@mathewc mathewc Awaiting requested review from mathewc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@surgupta-msft @kshyju @mathewc @liliankasem