Adding support for HTTP body binding #1712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattchenderson this will require doc updates. It would be great to avoid blocking on that, so happy to create a separate item if can track this separately. |
fabiocav
force-pushed
the
fabiocav/httpbindingsource
branch
from
11f7550
to
717b42e
Compare
fabiocav
changed the title
fabiocav
commented
Jul 4, 2023
kshyju
reviewed
Jul 5, 2023
extensions/Worker.Extensions.Http/src/IFromBodyConversionHandler.cs
Outdated
Show resolved
Hide resolved
extensions/Worker.Extensions.Http/src/DefaultFromBodyConversionFeature.cs
Show resolved
Hide resolved
extensions/Worker.Extensions.Http/src/DefaultFromBodyConversionFeature.cs
Outdated
Show resolved
Hide resolved
brettsam
reviewed
Jul 5, 2023
extensions/Worker.Extensions.Http/src/DefaultFromBodyConversionFeature.cs
Show resolved
Hide resolved
satvu
reviewed
Jul 5, 2023
fabiocav
force-pushed
the
fabiocav/httpbindingsource
branch
2 times, most recently
from
0633f6a
to
56945de
Compare
fabiocav
force-pushed
the
fabiocav/httpbindingsource
branch
from
56945de
to
bc4ea1d
Compare
brettsam
approved these changes
Jul 10, 2023
satvu
approved these changes
Jul 10, 2023
kshyju
approved these changes
Jul 10, 2023
kshyju
reviewed
Jul 10, 2023
fabiocav
force-pushed
the
fabiocav/httpbindingsource
branch
from
bc4ea1d
to
5057890
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
This PR introduces the ability to map custom attributes to converters, and leverages that capability to introduce a new attribute
FromBodyAttribute) in the HTTP extension, adding binding support for function parameters using the request body as the source (e.g., ability to bind,string,byte[], POCOs).resolves #164
Pull request checklist
release_notes.md