Updating test SDK reference and fixing HTTP E2E test app

Azure · Jul 11, 2023 · d54452e · d54452e
1 parent a27543a
commit d54452e
Show file tree

Hide file tree

Showing 14 changed files with 12 additions and 14 deletions.
diff --git a/extensions/Worker.Extensions.Http/src/DefaultFromBodyConversionFeature.cs b/extensions/Worker.Extensions.Http/src/DefaultFromBodyConversionFeature.cs
@@ -16,7 +16,7 @@ namespace Microsoft.Azure.Functions.Worker.Extensions.Http
 {
     internal class DefaultFromBodyConversionFeature : IFromBodyConversionFeature
     {
-        public static IFromBodyConversionFeature Instance { get; } = new DefaultFromBodyConversionFeature();
+        internal static IFromBodyConversionFeature Instance { get; } = new DefaultFromBodyConversionFeature();
 
         public ValueTask<object?> ConvertAsync(FunctionContext context, Type targetType)
         {

diff --git a/extensions/Worker.Extensions.Http/src/FromBodyAttribute.cs b/extensions/Worker.Extensions.Http/src/FromBodyAttribute.cs
@@ -7,7 +7,7 @@
 namespace Microsoft.Azure.Functions.Worker.Http
 {
     /// <summary>
-    /// Specifies that a parameter should be bound using the request body.
+    /// Specifies that a parameter should be bound using the HTTP request body when using the <see cref="HttpTriggerAttribute"/>.
     /// </summary>
     public class FromBodyAttribute : InputConverterAttribute
     {

diff --git a/extensions/Worker.Extensions.Http/src/FromBodyConverter.cs b/extensions/Worker.Extensions.Http/src/FromBodyConverter.cs
@@ -1,7 +1,6 @@
 // Copyright (c) .NET Foundation. All rights reserved.
 // Licensed under the MIT License. See License.txt in the project root for license information.
 
-using System;
 using System.Threading.Tasks;
 using Microsoft.Azure.Functions.Worker.Converters;
 

diff --git a/extensions/Worker.Extensions.Http/src/IFromBodyConversionHandler.cs b/extensions/Worker.Extensions.Http/src/IFromBodyConversionHandler.cs
@@ -17,7 +17,7 @@ public interface IFromBodyConversionFeature
         /// </summary>
         /// <param name="context">The <see cref="FunctionContext"/> for the invocation.</param>
         /// <param name="targetType">The target type for the conversion.</param>
-        /// <returns>A <see cref="ValueTask{TResult}"/> that completes when the converson is finished.</returns>
+        /// <returns>A <see cref="ValueTask{TResult}"/> that completes when the conversion is finished.</returns>
         ValueTask<object?> ConvertAsync(FunctionContext context, Type targetType);
     }
 }
diff --git a/test/DotNetWorkerTests/DotNetWorkerTests.csproj b/test/DotNetWorkerTests/DotNetWorkerTests.csproj
@@ -14,7 +14,7 @@
   <ItemGroup>
     <PackageReference Include="Microsoft.ApplicationInsights.WorkerService" Version="2.21.0" />
     <PackageReference Include="Microsoft.Azure.Core.NewtonsoftJson" Version="1.0.0" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.3" />
     <PackageReference Include="Moq" Version="4.18.2" />
     <PackageReference Include="xunit" Version="2.4.2" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">

diff --git a/test/E2ETests/E2EApps/E2EApp/Http/BasicHttpFunctions.cs b/test/E2ETests/E2EApps/E2EApp/Http/BasicHttpFunctions.cs
@@ -73,7 +73,7 @@ public class CallerName
 
         [Function(nameof(HelloWithNoResponse))]
         public static Task HelloWithNoResponse(
-            [HttpTrigger(AuthorizationLevel.Anonymous, "post", Route = null)][FromBody] HttpRequestData req,
+            [HttpTrigger(AuthorizationLevel.Anonymous, "post", Route = null)] HttpRequestData req,
             FunctionContext context)
         {
             var logger = context.GetLogger(nameof(HelloWithNoResponse));

diff --git a/test/E2ETests/E2ETests/E2ETests.csproj b/test/E2ETests/E2ETests/E2ETests.csproj
@@ -12,7 +12,7 @@
     <PackageReference Include="Azure.Storage.Queues" Version="12.12.0" />
     <PackageReference Include="Microsoft.Azure.DocumentDB.Core" Version="2.13.1" />
     <PackageReference Include="Microsoft.Extensions.Logging" Version="5.0.0" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.3" />
     <PackageReference Include="Moq" Version="4.18.2" />
     <PackageReference Include="xunit" Version="2.4.2" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">

diff --git a/test/E2ETests/E2ETests/HttpEndToEndTests.cs b/test/E2ETests/E2ETests/HttpEndToEndTests.cs
@@ -69,7 +69,6 @@ public async Task HttpTriggerTests_PocoFromBody(string functionName, string rout
             Assert.Equal(expectedBody, responseBody);
         }
 
-
         [Fact]
         public async Task HttpTriggerTests_PocoWithoutBindingSource()
         {

diff --git a/test/FunctionMetadataGeneratorTests/SdkTests.csproj b/test/FunctionMetadataGeneratorTests/SdkTests.csproj
@@ -12,7 +12,7 @@
 
   <ItemGroup>
     <PackageReference Include="Microsoft.Build.Utilities.Core" Version="17.4.0" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.3" />
     <PackageReference Include="Mono.Cecil" Version="0.11.3" />
     <PackageReference Include="Moq" Version="4.18.2" />    
     <PackageReference Include="xunit" Version="2.4.2" />

diff --git a/test/Sdk.Analyzers.Tests/Sdk.Analyzers.Tests/Sdk.Analyzers.Tests.csproj b/test/Sdk.Analyzers.Tests/Sdk.Analyzers.Tests/Sdk.Analyzers.Tests.csproj
@@ -7,7 +7,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.3" />
     <PackageReference Include="xunit" Version="2.4.2" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
       <PrivateAssets>all</PrivateAssets>

diff --git a/test/Sdk.Generator.Tests/Sdk.Generator.Tests.csproj b/test/Sdk.Generator.Tests/Sdk.Generator.Tests.csproj
@@ -21,7 +21,7 @@
     <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="5.0.0" />
     <PackageReference Include="Microsoft.Extensions.Hosting" Version="5.0.0" />
     <PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="5.0.0" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.3" />
     <PackageReference Include="xunit" Version="2.4.2" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>

diff --git a/test/SdkE2ETests/SdkE2ETests.csproj b/test/SdkE2ETests/SdkE2ETests.csproj
@@ -19,7 +19,7 @@
   <ItemGroup>
     <PackageReference Include="Microsoft.Build.Utilities.Core" Version="17.4.0" />
     <PackageReference Include="SharpZipLib" Version="1.4.1" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.4.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.3" />
     <PackageReference Include="xunit" Version="2.4.2" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">
       <PrivateAssets>all</PrivateAssets>

diff --git a/test/Worker.Extensions.Rpc.Tests/Worker.Extensions.Rpc.Tests.csproj b/test/Worker.Extensions.Rpc.Tests/Worker.Extensions.Rpc.Tests.csproj
@@ -11,7 +11,7 @@
 
   <ItemGroup>
     <PackageReference Include="System.Net.Http" Version="4.3.4" />
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.5.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.3" />
     <PackageReference Include="Moq" Version="4.18.2" />
     <PackageReference Include="xunit" Version="2.4.2" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">

diff --git a/test/Worker.Extensions.SignalRService.Tests/Worker.Extensions.SignalRService.Tests.csproj b/test/Worker.Extensions.SignalRService.Tests/Worker.Extensions.SignalRService.Tests.csproj
@@ -10,7 +10,7 @@
   </PropertyGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.5.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.6.3" />
     <PackageReference Include="xunit" Version="2.4.2" />
     <PackageReference Include="Moq" Version="4.18.2" />
     <PackageReference Include="xunit.runner.visualstudio" Version="2.4.5">