New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Core deferred binding feature #1676
Conversation
c34d51a
to
57fd122
Compare
Did first pass on the PR to check if all the needed files are included here -- looks good. Will do another pass for reviewing the PR. Question - what is the plan for bringing in sdk.analyzers and other tests - specially GrpcFunctionDefinitionTests and Metadata generator tests as all the functionality is here but we can't add their tests at this point? |
Thanks for confirming Surbhi, I mostly want to make sure everything we need is coming through, but doesn't hurt to do another PR pass just in case and we can address any additional feedback. For analyzers, I'd like to bring those in with their own PR. |
b157ac6
to
78a1b84
Compare
819d987
to
1ba086a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just a quick question about whether we need a public surface API review on this...
29ffaee
to
19531cc
Compare
19531cc
to
9ec2647
Compare
Cherry picking the core pieces of the deferred binding feature, leaving out all extension changes.
supportsDeferredBinding
metadata propertyresolves #1702