Skip to content

Commit

Permalink
Cherry pick cleanup
Browse files Browse the repository at this point in the history
  • Loading branch information
liliankasem committed Jun 23, 2023
1 parent 2c883d3 commit 57fd122
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 400 deletions.
20 changes: 10 additions & 10 deletions build/pipelines/templates/extensions-variables.yml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
variables:
${{ if and( not(contains(variables['Build.SourceBranch'], '/release/')), not(startsWith(variables['Build.SourceBranch'], 'refs/tags')) ) }}:
buildNumberTemp: $(Build.BuildNumber)
${{ if or( contains(variables['Build.SourceBranch'], '/release/'), startsWith(variables['Build.SourceBranch'], 'refs/tags') ) }}:
isReleaseBuildTemp: true
buildNumber: $[variables.buildNumberTemp]
isReleaseBuild: $[variables.isReleaseBuildTemp]
solution: '**/*.sln'
buildPlatform: 'Any CPU'
buildConfiguration: 'Release'
variables:
${{ if not(contains(variables['Build.SourceBranch'], '/release/' )) }}:
buildNumberTemp: $(Build.BuildNumber)
${{ if contains(variables['Build.SourceBranch'], '/release/' ) }}:
isReleaseBuildTemp: true
buildNumber: $[variables.buildNumberTemp]
isReleaseBuild: $[variables.isReleaseBuildTemp]
solution: '**/*.sln'
buildPlatform: 'Any CPU'
buildConfiguration: 'Release'
2 changes: 1 addition & 1 deletion release_notes.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,4 @@
### Microsoft.Azure.Functions.Worker.Sdk

- Added retries on `IOException` when writing `function.metadata` file as part of `GenerateFunctionMetadata` msbuild task. This is to allow builds to continue (with warnings) when another process has the file momentarily locked. If the file continues to be locked the task (and build) will fail after 10 retries with a 1 second delay each. (#1532)
- Implementation for bypass deferred binding (#1462/#1495)
- Implementation for deferred binding feature (#1676)
4 changes: 2 additions & 2 deletions src/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ jobs:
- ImageOverride -equals MMS2022TLS

variables:
${{ if and( not(contains(variables['Build.SourceBranch'], '/release/')), not(startsWith(variables['Build.SourceBranch'], 'refs/tags')) ) }}:
${{ if not(contains(variables['Build.SourceBranch'], '/release/' )) }}:
buildNumberTemp: $(Build.BuildNumber)
${{ if or( contains(variables['Build.SourceBranch'], '/release/'), startsWith(variables['Build.SourceBranch'], 'refs/tags') ) }}:
${{ if contains(variables['Build.SourceBranch'], '/release/' ) }}:
isReleaseBuildTemp: true
buildNumber: $[variables.buildNumberTemp]
isReleaseBuild: $[variables.isReleaseBuildTemp]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ public Task<ImmutableArray<IFunctionMetadata>> GetFunctionMetadataAsync(string d
var metadataList = new List<IFunctionMetadata>();
var Function0RawBindings = new List<string>();
Function0RawBindings.Add(@"{""name"":""req"",""type"":""HttpTrigger"",""direction"":""In"",""authLevel"":""Anonymous"",""methods"":[""get"",""post""]}");
Function0RawBindings.Add(@"{""name"":""myBlob"",""type"":""Blob"",""direction"":""In"",""properties"":{""supportsDeferredBinding"":""True""},""blobPath"":""test-samples/sample1.txt"",""connection"":""AzureWebJobsStorage"",""cardinality"":""One"",""dataType"":""String""}");
Function0RawBindings.Add(@"{""name"":""myBlob"",""type"":""Blob"",""direction"":""In"",""blobPath"":""test-samples/sample1.txt"",""connection"":""AzureWebJobsStorage"",""cardinality"":""One"",""dataType"":""String""}");
Function0RawBindings.Add(@"{""name"":""Book"",""type"":""Queue"",""direction"":""Out"",""queueName"":""functionstesting2"",""connection"":""AzureWebJobsStorage""}");
Function0RawBindings.Add(@"{""name"":""HttpResponse"",""type"":""http"",""direction"":""Out""}");

Expand Down

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ public Task<ImmutableArray<IFunctionMetadata>> GetFunctionMetadataAsync(string d
metadataList.Add(Function0);
var Function1RawBindings = new List<string>();
Function1RawBindings.Add(@"{""name"":""$return"",""type"":""Queue"",""direction"":""Out"",""queueName"":""queue2""}");
Function1RawBindings.Add(@"{""name"":""blob"",""type"":""BlobTrigger"",""direction"":""In"",""properties"":{""supportsDeferredBinding"":""True""},""path"":""container2/%file%"",""dataType"":""String""}");
Function1RawBindings.Add(@"{""name"":""blob"",""type"":""BlobTrigger"",""direction"":""In"",""path"":""container2/%file%"",""dataType"":""String""}");

var Function1 = new DefaultFunctionMetadata
{
Expand All @@ -219,8 +219,8 @@ public Task<ImmutableArray<IFunctionMetadata>> GetFunctionMetadataAsync(string d
metadataList.Add(Function1);
var Function2RawBindings = new List<string>();
Function2RawBindings.Add(@"{""name"":""$return"",""type"":""Queue"",""direction"":""Out"",""queueName"":""queue2""}");
Function2RawBindings.Add(@"{""name"":""blobs"",""type"":""Blob"",""direction"":""In"",""properties"":{""supportsDeferredBinding"":""True""},""blobPath"":""container2"",""cardinality"":""Many"",""dataType"":""String""}");

Function2RawBindings.Add(@"{""name"":""blobs"",""type"":""Blob"",""direction"":""In"",""blobPath"":""container2"",""cardinality"":""Many"",""dataType"":""String""}");
var Function2 = new DefaultFunctionMetadata
{
Language = "dotnet-isolated",
Expand Down

0 comments on commit 57fd122

Please sign in to comment.