Add binding attribute to converter context #1660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviau
approved these changes
Jun 21, 2023
src/DotNetWorker.Core/Context/Features/DefaultFunctionInputBindingFeature.cs
Outdated
Show resolved
Hide resolved
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
fabiocav
reviewed
Jun 22, 2023
src/DotNetWorker.Core/Context/Features/DefaultFunctionInputBindingFeature.cs
Show resolved
Hide resolved
liliankasem
force-pushed
the
lk/add-attribute-convertercontext
branch
from
eee6e02
to
fd61026
Compare
liliankasem
force-pushed
the
feature/sdk-type-binding
branch
from
e59563c
to
bcaf5e7
Compare
liliankasem
force-pushed
the
lk/add-attribute-convertercontext
branch
from
15f91fc
to
51bce80
Compare
fabiocav
reviewed
Jun 26, 2023
src/DotNetWorker.Core/Context/Features/DefaultFunctionInputBindingFeature.cs
Show resolved
Hide resolved
7 tasks
fabiocav
reviewed
Jun 27, 2023
src/DotNetWorker.Core/Converters/Converter/ConverterContextExtensions.cs
Outdated
Show resolved
Hide resolved
liliankasem
force-pushed
the
lk/add-attribute-convertercontext
branch
from
a867b61
to
b6598dd
Compare
liliankasem
added a commit
that referenced
this pull request
Jun 28, 2023
liliankasem
added a commit
that referenced
this pull request
Jun 28, 2023
liliankasem
added a commit
that referenced
this pull request
Jul 5, 2023
liliankasem
added a commit
that referenced
this pull request
Jul 7, 2023
liliankasem
added a commit
that referenced
this pull request
Jul 7, 2023
liliankasem
added a commit
that referenced
this pull request
Jul 7, 2023
liliankasem
added a commit
that referenced
this pull request
Jul 7, 2023
liliankasem
added a commit
that referenced
this pull request
Jul 7, 2023
liliankasem
added a commit
that referenced
this pull request
Jul 10, 2023
liliankasem
added a commit
that referenced
this pull request
Jul 11, 2023
liliankasem
added a commit
that referenced
this pull request
Jul 11, 2023
liliankasem
added a commit
that referenced
this pull request
Jul 11, 2023
liliankasem
added a commit
that referenced
this pull request
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the binding attribute for a given parameter to the converter context, this enables converters to have all the information they need about the attribute a parameter is using without having to make a roundtrip to WebJobs.