New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support sdk-type binding reference type #1107
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 12, 2022
mathewc
reviewed
Oct 21, 2022
extensions/Worker.Extensions.Abstractions/src/ExtensionInformationAttribute.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Oct 21, 2022
extensions/Worker.Extensions.Abstractions/src/ReferenceTypeAttribute.cs
Outdated
Show resolved
Hide resolved
mathewc
reviewed
Oct 21, 2022
mathewc
reviewed
Oct 21, 2022
mathewc
reviewed
Oct 21, 2022
mathewc
reviewed
Oct 21, 2022
liliankasem
commented
Oct 26, 2022
liliankasem
commented
Oct 26, 2022
mathewc
reviewed
Oct 27, 2022
mathewc
reviewed
Oct 27, 2022
mathewc
reviewed
Oct 27, 2022
liliankasem
force-pushed
the
sdk-bindings/reference-support
branch
from
November 1, 2022 22:15
8730ea9
to
7817039
Compare
liliankasem
force-pushed
the
sdk-bindings/reference-support
branch
from
November 1, 2022 22:16
7817039
to
084dced
Compare
liliankasem
commented
Nov 2, 2022
extensions/Worker.Extensions.Abstractions/src/ExtensionInformationAttribute.cs
Show resolved
Hide resolved
mathewc
reviewed
Nov 2, 2022
mathewc
reviewed
Nov 2, 2022
mathewc
reviewed
Nov 2, 2022
…zure/azure-functions-dotnet-worker into sdk-bindings/reference-support
…zure/azure-functions-dotnet-worker into sdk-bindings/reference-support
/check-enforcer evaluate |
mathewc
approved these changes
Nov 3, 2022
/check-enforcer evaluate |
This was referenced Nov 3, 2022
7 tasks
liliankasem
added a commit
that referenced
this pull request
Jul 11, 2023
liliankasem
added a commit
that referenced
this pull request
Jul 11, 2023
liliankasem
added a commit
that referenced
this pull request
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue describing the changes in this PR
Related epic: #1081
Part of the work to support SDK-type bindings for out-of-proc workers is to let the host know when an extension supports "deferred binding". Deferred binding means that instead of the host resolving bindings, it will be deferred so that the worker does the binding when it gets the invocation request. You can see how we intend to handle that deferred binding by looking at the Blob Converter PR.
Things happening in this PR:
The abstractions project has been updated so that
ExtensionInformationAttribute
has a flag (SupportsDeferredBinding)that extensions can use to indicate that they support deferred binding (on the extension side, it means that they have a converter for ParameterBindingData, you can look what this looks like in the blob extension PR)
The SDK will check to see if a given extension supports deferred binding (meaning it has
SupportsDeferredBinding
set to true), and if it does it will add a "supportsDeferredBinding" flag to the bindingProperties
. This flag tells the host that a given function supports deferred binding and to use ParameterBindingData as the function's "DefaultType" - you can learn more about that in the host PR.Finally, the worker needs a representation of ParameterBindingData. This is actually defined in the protobuf as ModelBindingData. We create an abstract class to represent the
ModelBindingData
message that is generated in the gRPC layer.The epic has a list of all the PRs related to this feature.
Pull request checklist
release_notes.md
Additional information
Additional PR information