{AKS} Extend --data-collection-settings with containerlogv2
#26793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wanlonghenry
requested review from
zhoxing-ms,
andyliuliming,
jsntcy and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
ghost
assigned 
|
AKS |
ghost
requested review from
|
|
ganga1980
approved these changes
Jun 30, 2023
|
@zhoxing-ms @yonzhan could you review this PR when available, thank you! |
FumingZhang
reviewed
Jul 3, 2023
src/azure-cli/azure/cli/command_modules/acs/addonconfiguration.py
Outdated
Show resolved
Hide resolved
|
@zhoxing-ms @yonzhan @FumingZhang addressed the comment, could you review this again. Also there is one check failing but that looks like general issue, please confirm and retrigger the test when that is fixed, thank you! |
|
@wanlonghenry This is a known issue related to pydantic pydantic/pydantic#6361, we are tracking it |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
Commenter does not have sufficient privileges for PR 26793 in repo Azure/azure-cli |
zhoxing-ms
approved these changes
Jul 7, 2023
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Description
Extend DataCollectionSettings JSON for containerlogv2
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.