-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tenant scope deployments for the ARM Deploy action #125
Added tenant scope deployments for the ARM Deploy action #125
Conversation
Hi @bishal-pdMSFT & @t-dedah! Let me know if you need any changes to get this pulled through. Thanks! |
Hi @kanika1894, @microsoftopensource, Anyone that can comments on this PR? Thanks! |
Would it be possible for someone to review and pass the pull request? I'm waiting for this update. |
@bishal-pdMSFT, @t-dedah, would it be possible to take a look at this request? Many thanks! |
@microsoftopensource, @bishal-pdMSFT, @t-dedah, @kanika1894, @fvilches17, @pulkitaggarwl, @PankajGovindRao, @tomkerkhove, @larryclaman, @tejasd1990, @harvey-k, @zainuvk, @N-Usha: Would any of you be able to look at this request? It would be a cool feature if you could still get to it and merge. Thank you! 🙏🏻 |
I do not work on ARM |
Apologies, given that this has been open for 2 years I simply took everyone who has ever committed to this repo. If you could help ping/nudge someone to take a look that is still involved, that'd be awesome. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing, and I apologize for the delay in merging this!
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [azure/arm-deploy](https://togithub.com/azure/arm-deploy) | action | major | `v1` -> `v2` | --- ### Release Notes <details> <summary>azure/arm-deploy (azure/arm-deploy)</summary> ### [`v2`](https://togithub.com/Azure/arm-deploy/releases/tag/v2) [Compare Source](https://togithub.com/azure/arm-deploy/compare/v1...v2) ##### Highlights - Added tenant scope deployments for the ARM Deploy action by [@​bearmannl](https://togithub.com/bearmannl) in [https://github.com/Azure/arm-deploy/pull/125](https://togithub.com/Azure/arm-deploy/pull/125) - Upgrade to Node 20 by [@​anthony-c-martin](https://togithub.com/anthony-c-martin) in [https://github.com/Azure/arm-deploy/pull/142](https://togithub.com/Azure/arm-deploy/pull/142) **Full Changelog**: Azure/arm-deploy@v1.0.8...v2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 7am on Sunday,before 7am on Wednesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/digdir/dialogporten). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yMDAuMCIsInVwZGF0ZWRJblZlciI6IjM3LjIwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [azure/arm-deploy](https://togithub.com/azure/arm-deploy) | action | major | `v1` -> `v2` | --- ### Release Notes <details> <summary>azure/arm-deploy (azure/arm-deploy)</summary> ### [`v2`](https://togithub.com/Azure/arm-deploy/releases/tag/v2) [Compare Source](https://togithub.com/azure/arm-deploy/compare/v1...v2) #### Highlights - Added tenant scope deployments for the ARM Deploy action by [@​bearmannl](https://togithub.com/bearmannl) in [https://github.com/Azure/arm-deploy/pull/125](https://togithub.com/Azure/arm-deploy/pull/125) - Upgrade to Node 20 by [@​anthony-c-martin](https://togithub.com/anthony-c-martin) in [https://github.com/Azure/arm-deploy/pull/142](https://togithub.com/Azure/arm-deploy/pull/142) **Full Changelog**: Azure/arm-deploy@v1.0.8...v2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 7am on Sunday,before 7am on Wednesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/digdir/dialogporten). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Title pretty much says it all.
Added a deployment scope for tenant level deployments. This is specifically required if you wish to deploy from the root management group level.
I did not get to test the CI pipeline test cases in my own environment.