Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added _windowProperties override to Win32.EmbeddedWindowImpl #14649

Merged

Conversation

Basnederveen
Copy link
Contributor

@Basnederveen Basnederveen commented Feb 19, 2024

What does the pull request do?

Overrides the resizable and SystemDecorations properties of an embedded window.

What is the current behavior?

Shows chrome and is resizable. Parent control should control the size of a child.

What is the updated/expected behavior with this PR?

No chrome when embedding an avalonia control in a winforms application

Checklist

Fixed issues

Fixes #14640

@Basnederveen
Copy link
Contributor Author

@dotnet-policy-service agree

@timunie
Copy link
Contributor

timunie commented Feb 19, 2024

Fixed [https://github.com//issues/14640 ]

NIT: should be Fixes #14640 to make the PR closing the issue iirc.

@Basnederveen
Copy link
Contributor Author

Edited..

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0045061-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@maxkatz6 maxkatz6 added this pull request to the merge queue Feb 19, 2024
@maxkatz6 maxkatz6 added backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch os-windows labels Feb 19, 2024
Merged via the queue into AvaloniaUI:master with commit 1e078c4 Feb 19, 2024
6 checks passed
@maxkatz6 maxkatz6 added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Feb 20, 2024
maxkatz6 pushed a commit that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avalonia control embedded in windows forms shows chrome
4 participants