Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes/revert x11 popup changes #14573

Merged
merged 2 commits into from
Feb 10, 2024
Merged

Conversation

kekekeks
Copy link
Member

#14366 has basically broken popups and made them constrained to the window itself. This is a major breaking change for most of actual desktop apps, so it's getting reverted alongside with later positioning fix.

@kekekeks kekekeks merged commit 76caeed into master Feb 10, 2024
1 of 5 checks passed
@kekekeks kekekeks deleted the fixes/revert-x11-popup-changes branch February 10, 2024 10:34
@kekekeks kekekeks added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Feb 10, 2024
@kekekeks
Copy link
Member Author

@marysaka I can't check with gamescope since it refuses to run properly on my hardware, but from your description it seems that it's ignoring override_redirect flag on XWayland windows, so I'd suggest to try setting WM_TRANSIENT_FOR hint for popups and see if it helps.

kekekeks added a commit that referenced this pull request Feb 10, 2024
* Revert "Fix popups position on X11 (#14551)"

This reverts commit 06f88f6.

* Revert "Use popupParent as X11 parent window (#14366)"

This reverts commit 0bde86b.
@marysaka
Copy link
Contributor

@marysaka I can't check with gamescope since it refuses to run properly on my hardware, but from your description it seems that it's ignoring override_redirect flag on XWayland windows, so I'd suggest to try setting WM_TRANSIENT_FOR hint for popups and see if it helps.

I will try to give that a shot this week-end.

@marysaka
Copy link
Contributor

@kekekeks WM_TRANSIENT_FOR hint doesn't change a thing, however I found part of the issue.

if _useRenderWindow is set to false, the rendering does work properly. Considering the comment attached on it, would it be acceptable to set it to false when using a popup because as far as I know popup cannot be resized?

maxkatz6 pushed a commit that referenced this pull request Feb 14, 2024
* Revert "Fix popups position on X11 (#14551)"

This reverts commit 06f88f6.

* Revert "Use popupParent as X11 parent window (#14366)"

This reverts commit 0bde86b.
@maxkatz6 maxkatz6 removed the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants