Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ScrollIntoView into ItemsControl. #14538

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

grokys
Copy link
Member

@grokys grokys commented Feb 8, 2024

What does the pull request do?

As described in #14524, ScrollIntoView is useful in ItemsControl in general and shouldn't be only available in SelectingItemsControl and derived.

Moving a method to a base class isn't a breaking change according to the MS docs so this should be OK.

✔️ ALLOWED: Moving a member into a class higher in the hierarchy than the type from which it was removed

Fixed issues

Fixes #14524

@grokys grokys added the backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch label Feb 8, 2024
@grokys
Copy link
Member Author

grokys commented Feb 8, 2024

Not sure if this should be a backport candidate or not? On the one hand it's a simple change, on the other hand I kinda feel like it might be a breaking change in some way, even if the MS docs say it's not...

@avaloniaui-bot
Copy link

You can test this PR using the following package version. 11.1.999-cibuild0044625-beta. (feed url: https://nuget-feed-all.avaloniaui.net/v3/index.json) [PRBUILDID]

@thevortexcloud
Copy link
Contributor

thevortexcloud commented Feb 9, 2024

On the one hand it's a simple change, on the other hand I kinda feel like it might be a breaking change in some way,

I can't see how unless there is some weirdness with some of the existing controls suddenly changing scroll position. There should be no existing dependencies on the functionality on any of the controls using the newly gained functionality. But I imagine you would have a better idea than me about how all the pieces interact with each other.

@grokys grokys added this pull request to the merge queue Feb 9, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 9, 2024
@maxkatz6 maxkatz6 merged commit 7b9a487 into master Feb 9, 2024
7 checks passed
@maxkatz6 maxkatz6 deleted the fixes/14524-itemscontrol-scrollintoview branch February 9, 2024 22:20
maxkatz6 pushed a commit that referenced this pull request Feb 14, 2024
@maxkatz6 maxkatz6 added backported-11.0.x and removed backport-candidate-11.0.x Consider this PR for backporting to 11.0 branch labels Feb 20, 2024
maxkatz6 pushed a commit that referenced this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing ScrollIntoView primitives in ItemsControl, are present in SelectingItemsControl
4 participants