fix: Remove count() from TypeScript definitions #14076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbdelrahmanHafez
approved these changes
Nov 12, 2023
AbdelrahmanHafez
requested changes
Nov 12, 2023
There was a problem hiding this comment.
Can you please rebase your branch on 8.0 since #13618 seems to be merged into 8.0 branch.
|
Going to merge this into a separate branch so I can fix up the test failures |
vkarpov15
merged commit 1667acb
into
Automattic:vkarpov15/gh-14076
2 of 3 checks passed
vkarpov15
added a commit
that referenced
this pull request
Nov 14, 2023
|
Thanks for taking over @vkarpov15 and @AbdelrahmanHafez! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
After #13618 was merged, the now missing
count()function was not removed from the types.cc @IslandRhythms