Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove id setter #13864

Merged
merged 1 commit into from
Sep 15, 2023
Merged

remove id setter #13864

merged 1 commit into from
Sep 15, 2023

Conversation

IslandRhythms
Copy link
Collaborator

@IslandRhythms IslandRhythms commented Sep 15, 2023

closes #13784

@vkarpov15 vkarpov15 added this to the 8.0 milestone Sep 15, 2023
@vkarpov15 vkarpov15 merged commit 77d5b19 into 8.0 Sep 15, 2023
37 of 38 checks passed
@vkarpov15 vkarpov15 deleted the IslandRhythms/remove-id-setter branch September 15, 2023 19:40
@OIRNOIR
Copy link

OIRNOIR commented Sep 16, 2023

Yall this is a breaking change
See #13867

@vkarpov15
Copy link
Collaborator

This change went into 8.0 branch, not master, so hasn't been released yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants