Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent camelCase Naming in lib dir #13490

Closed
wants to merge 0 commits into from

Conversation

Ashu3208
Copy link

@Ashu3208 Ashu3208 commented Jun 8, 2023

Summary
This fixes #13308

I have made consistent naming of the files in lib directory . I have used camel case naming for the same. I have also updated the imports. I have also run npm test to ensure that all the imports are updated.
This pull request is in reference to issue

Examples

@Ashu3208 Ashu3208 changed the title Consistent camelCase Naming in lib dir #13308 Consistent camelCase Naming in lib dir Jun 9, 2023
@hasezoey hasezoey added this to the 8.0 milestone Jun 13, 2023
@hasezoey
Copy link
Collaborator

i have looked through, and it seems like not every file was updated, examples: lib/options/* or lib/schema/* or lib/types/*

also seems like some files were renamed but not updated everywhere (see failing tests)

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. We really should have a more consistent file naming strategy, but we will have to merge this change into 8.0 because it may be backwards breaking.

@Ashu3208 Ashu3208 closed this Jul 1, 2023
@Ashu3208 Ashu3208 force-pushed the ashutosh branch 2 times, most recently from 8a6c03f to 9482716 Compare July 1, 2023 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[meta] change file naming to be consistent
3 participants