remove count()
#13618
Merged
remove count()
#13618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
vkarpov15
approved these changes
Jul 18, 2023
alecgibson
added a commit
to alecgibson/adminjs-mongoose
that referenced
this pull request
Nov 1, 2023
This library doesn't work with [`mongoose@8`][1]. At the very least, `mongoose@8` [drops support][2] for `.count()`, which this library [still uses][3]. As a quick note to other developers, this change updates the peer dependency requirement to not include `mongoose@8`. [1]: https://github.com/Automattic/mongoose/blob/master/CHANGELOG.md#800-rc0--2023-10-24 [2]: Automattic/mongoose#13618 [3]: https://github.com/SoftwareBrothers/adminjs-mongoose/blob/fd8ad92e81da8f61da6759e2c4c9a020d88bc2b6/src/resource.ts#L71
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.