Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "nullable annotations for the runtime public API" #4388

Merged
merged 1 commit into from Feb 7, 2024

Conversation

jbogard
Copy link
Member

@jbogard jbogard commented Feb 7, 2024

This reverts commit 7bd1b81.

@jbogard jbogard merged commit f137534 into master Feb 7, 2024
3 checks passed
@jbogard jbogard deleted the revert-nullables branch February 7, 2024 21:27
@lbargaoanu lbargaoanu added this to the 13.0.1 milestone Feb 8, 2024
@mikegoatly
Copy link

@jbogard would NotNullIfNotNull help here? (https://learn.microsoft.com/en-us/dotnet/api/system.diagnostics.codeanalysis.notnullifnotnullattribute?view=net-8.0)

e.g.

TDestination? Map<TSource, TDestination>([NotNullIfNotNull (nameof (source))] TSource? source);

@jbogard
Copy link
Member Author

jbogard commented Feb 9, 2024

Yeah I'm going to open another issue to discuss exactly what changes could/should be made based on expected/supported behaviors.

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants