Revert "Only evaluate own String/Number/Math methods (babel#16033)"

This reverts commit b13376b.
Astrabacus · Nov 5, 2023 · 9ec1cb5 · 9ec1cb5
1 parent dab8e95
commit 9ec1cb5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 11 deletions.
diff --git a/packages/babel-traverse/src/path/evaluation.ts b/packages/babel-traverse/src/path/evaluation.ts
@@ -444,11 +444,8 @@ function _evaluate(path: NodePath, state: State): any {
         !isInvalidMethod(property.node.name)
       ) {
         context = global[object.node.name];
-        const key = property.node.name;
-        // TODO(Babel 8): Use Object.hasOwn
-        if (Object.hasOwnProperty.call(context, key)) {
-          func = context[key as keyof typeof context];
-        }
+        // @ts-expect-error property may not exist in context object
+        func = context[property.node.name];
       }
 
       // "abc".charCodeAt(4)

diff --git a/packages/babel-traverse/test/evaluation.js b/packages/babel-traverse/test/evaluation.js
@@ -152,12 +152,6 @@ describe("evaluation", function () {
     expect(eval_invalid_call.confident).toBe(false);
   });
 
-  it("should not evaluate inherited methods", function () {
-    const path = getPath("Math.hasOwnProperty('min')");
-    const evalResult = path.get("body.0.expression").evaluate();
-    expect(evalResult.confident).toBe(false);
-  });
-
   it("should evaluate global call expressions", function () {
     expect(
       getPath("isFinite(1);").get("body.0.expression").evaluate().value,