Skip to content

Commit

Permalink
Merge pull request #147 from Artemis-chan/osu-bump
Browse files Browse the repository at this point in the history
Update to osu!
  • Loading branch information
Artemis-chan committed Feb 20, 2024
2 parents d6aa9a1 + eb1ff95 commit d2624c9
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
</ItemGroup>
<PropertyGroup Label="Project">
<OutputType>WinExe</OutputType>
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<RootNamespace>osu.Game.Rulesets.Diva.Tests</RootNamespace>
</PropertyGroup>
</Project>
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
using osu.Game.Rulesets.Diva.Judgements;
using osu.Game.Rulesets.Judgements;
using osu.Framework.Input.Events;
using osu.Game.Rulesets.Objects;

namespace osu.Game.Rulesets.Diva.Objects.Drawables
{
Expand Down Expand Up @@ -129,6 +130,8 @@ public override void PlaySamples()
{
}

protected static void ApplyMiss(JudgementResult r, DrawableHitObject s) => r.Type = HitResult.Miss;

protected override void CheckForResult(bool userTriggered, double timeOffset)
{
if (Judged)
Expand All @@ -139,7 +142,7 @@ protected override void CheckForResult(bool userTriggered, double timeOffset)

if (!HitObject.HitWindows.CanBeHit(timeOffset) && base.Time.Current > HitObject.StartTime)
{
ApplyResult(r => r.Type = HitResult.Miss);
ApplyResult(ApplyMiss);
return;
}

Expand All @@ -150,9 +153,9 @@ protected override void CheckForResult(bool userTriggered, double timeOffset)
if (pressed && timeOffset > (-time_action))
{
if (validPress)
ApplyResult(r => r.Type = result);
ApplyResult((r, s) => r.Type = result);
else
ApplyResult(r => r.Type = HitResult.Miss);
ApplyResult(ApplyMiss);
pressed = false;
}
}
Expand Down
6 changes: 3 additions & 3 deletions osu.Game.Rulesets.Diva/osu.Game.Rulesets.Diva.csproj
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup Label="Project">
<TargetFramework>net6.0</TargetFramework>
<TargetFramework>net8.0</TargetFramework>
<AssemblyTitle>osu.Game.Rulesets.Sample</AssemblyTitle>
<OutputType>Library</OutputType>
<PlatformTarget>AnyCPU</PlatformTarget>
Expand All @@ -13,7 +13,7 @@
<Folder Include="Resources\Textures" />
</ItemGroup>
<ItemGroup>
<PackageReference Include="ppy.osu.Game" Version="2024.131.0" />
<PackageReference Include="ppy.osu.Game.Rulesets.Osu" Version="2024.131.0" />
<PackageReference Include="ppy.osu.Game" Version="2024.219.0" />
<PackageReference Include="ppy.osu.Game.Rulesets.Osu" Version="2024.219.0" />
</ItemGroup>
</Project>

0 comments on commit d2624c9

Please sign in to comment.