Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: heading node validate failed #5370

Merged
merged 1 commit into from
May 20, 2024

Conversation

LucasXu0
Copy link
Collaborator

@LucasXu0 LucasXu0 commented May 20, 2024

Feature Preview

  • Add a missing delta value for heading blocks if their delta is empty.
  • Fix error block overflow on mobile.

PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

Copy link

github-actions bot commented May 20, 2024

🥷 Ninja i18n – 🛎️ Translations need to be updated

Project /project.inlang

lint rule new reports level link
Missing translation 25 warning contribute (via Fink 🐦)

@LucasXu0 LucasXu0 added bug Something isn't working v0.5.8 labels May 20, 2024
),
const VSpace(6),
FlowyText.regular(
'(${LocaleKeys.document_errorBlock_clickToCopyTheBlockContent.tr()})',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could just add the parantheses to the localisation.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking it would be a little bit redundant to add the parentheses to the translation. So I just added it here.

@LucasXu0 LucasXu0 merged commit 0c0bd54 into AppFlowy-IO:main May 20, 2024
16 checks passed
zoli added a commit to zoli/AppFlowy that referenced this pull request May 21, 2024
* main:
  fix: unable to remove the remote selection when the user close the page on mobile (AppFlowy-IO#5376)
  chore: add limitation when importing csv file (AppFlowy-IO#5381)
  fix: infinite loop when getting ancestor for orphan view (AppFlowy-IO#5375)
  fix: range error raise if heading level >= 6 (AppFlowy-IO#5373)
  fix: use full update states instead of patch update (AppFlowy-IO#5371)
  chore: update translations to consistently use appName instead of AppFlowy (AppFlowy-IO#5354)
  fix: changing field type from text to checkbox causes exception AppFlowy-IO#5360 (AppFlowy-IO#5366)
  fix: heading node validate failed (AppFlowy-IO#5370)
  chore: support Ukrainian language AppFlowy-IO#5350 (AppFlowy-IO#5369)
  chore: do not use the cell of given summary field (AppFlowy-IO#5362)
  chore: update translations with Fink 🐦 (AppFlowy-IO#5322)
  chore: update fr-FR.json (AppFlowy-IO#5356)
  fix: workspace icon displays incorrectly on Linux (AppFlowy-IO#5358)
  feat: support web grid preview (AppFlowy-IO#5353)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v0.5.8
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants