Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove workaround for windows flutter ci #4957

Merged

Conversation

richardshiue
Copy link
Collaborator

@richardshiue richardshiue commented Mar 21, 2024

An upstream fix was merged recently that allows us to move away from this workaround subosito/flutter-action#280

Feature Preview


PR Checklist

  • My code adheres to AppFlowy's Conventions
  • I've listed at least one issue that this PR fixes in the description above.
  • I've added a test(s) to validate changes in this PR, or this PR only contains semantic changes.
  • All existing tests are passing.

@richardshiue richardshiue force-pushed the chore/remove-flutter-ci-workaround branch from 1240905 to af18272 Compare March 21, 2024 06:38
@richardshiue richardshiue force-pushed the chore/remove-flutter-ci-workaround branch from af18272 to 6ab1197 Compare March 21, 2024 06:42
@LucasXu0
Copy link
Collaborator

Please update this repo as well. https://github.com/AppFlowy-IO/AppFlowy-Builder/blob/main/.github/workflows/windows.yaml

@richardshiue
Copy link
Collaborator Author

Please update this repo as well. https://github.com/AppFlowy-IO/AppFlowy-Builder/blob/main/.github/workflows/windows.yaml

Sure thing

@richardshiue richardshiue merged commit 98876b1 into AppFlowy-IO:main Mar 21, 2024
10 checks passed
@richardshiue richardshiue deleted the chore/remove-flutter-ci-workaround branch March 21, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants