Solve the problem of insufficient width of Y-axis label display

[weilanxiao]

No description provided.

[hannesa2]

Some screenshot tests are failing, but maybe it's ok, because you changed something.
The annoying thing is, that you have to download diff files in pull request summary, for investigation.

To avoid this, I made #213 here you see diff immediate in pull request as comment.

@weilanxiao Please rebase this pull request to recent master, then we can see diffs immediate

[weilanxiao]

Hello, I created a new branch based on the latest master where the commit is 12fa970f, and then picked the original commits to the new branch. Finally, I forcefully pushed to fix_y_label_width. Is this operation correct?

[hannesa2]

The new branch was an extra unneeded task, but the result is fine
The easiest way to rebase would be:

git fetch upstream
git checkout fix_y_label_width
git rebase upstream/master
git push -f

[hannesa2]

Now I started the CI pipeline and I expect failing screenshot test, because I already tested this branch concerning screenshot tests #216 and there is already a fix be47f36
I don't want to merge my pull request, because then I'm in the history as creator of this fix. I don't want to grab the honor of your fix, so I help you to fix, to habe the honor on your side.

A:

To fix it, the most easy step is to cherry-pick be47f36 to your pull request.

B:

A more complicated way it to grab new screenshots from failing CI pipeline and replace in directory screenshotsToCompare with these new artifacts

C:

I simply merge #216 but then you are not the creator of this fix in changelog

[hannesa2]

Btw, I see my screenshot pipeline don't find secret CLASSIC_TOKEN for pull request form a fork, that's why the screenshot diffs are not pushed to this pull request, compared to #216

[hannesa2]

A:

To fix it, the most easy step is to cherry-pick be47f36 to your pull request.

I did this, because I can push to a branch of your repository

[weilanxiao]

How should I add CLASSIC_TOKEN through this check?

[hannesa2]

How should I add CLASSIC_TOKEN through this check?

No action required. Build is green
Thank you !

[weilanxiao]

Thank you

[hannesa2]

Here you go https://github.com/AppDevNext/AndroidChart/releases/tag/3.1.0.22