Split the thread-id TLS into 2 variables #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the fast path to avoid a branch which checks if the TLS destructor for the thread ID has been registered.
terrarier2111
added a commit
to terrarier2111/thread_local-rs
that referenced
this pull request
Dec 14, 2022
|
Is there a reason this didn't get merged yet? (sorry to bother you again about this) |
|
Published 1.1.5. |
Amanieu
added a commit
that referenced
this pull request
Feb 10, 2023
This was introduced in #44 but is actually broken since a thread could be assigned the ID of an existing slot in the table if another thread previously using that ID has exited.
Amanieu
added a commit
that referenced
this pull request
Feb 10, 2023
This was introduced in #44 but is actually broken since a thread could be assigned the ID of an existing slot in the table if another thread previously using that ID has exited.
terrarier2111
pushed a commit
to terrarier2111/thread_local-rs
that referenced
this pull request
Jun 13, 2023
This was introduced in Amanieu#44 but is actually broken since a thread could be assigned the ID of an existing slot in the table if another thread previously using that ID has exited.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the fast path to avoid a branch which checks if the TLS
destructor for the thread ID has been registered.