miri reports leaking memory with 1.1.5

[TimDiekmann]

Hello 👋🏻

With the latest release of thread_local, miri reports a memory leak. I tracked this down to the version bump of thread_local v1.1.5.

This is the output of miri:

     Running tests/test_span_trace.rs (target/miri/x86_64-unknown-linux-gnu/debug/deps/test_span_trace-315bdddcdb7b9126)

running 2 tests
test captured ... ok
test provided ... ok

test result: ok. 2 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out

The following memory was leaked: alloc281964 (Rust heap, size: 64, align: 8) {
    0x00 │ 01 00 00 00 00 00 00 00 00 __ __ __ __ __ __ __ │ .........░░░░░░░
    0x10 │ 02 00 00 00 00 00 00 00 00 __ __ __ __ __ __ __ │ .........░░░░░░░
    0x20 │ __ __ __ __ __ __ __ __ __ __ __ __ __ __ __ __ │ ░░░░░░░░░░░░░░░░
    0x30 │ __ __ __ __ __ __ __ __ __ __ __ __ __ __ __ __ │ ░░░░░░░░░░░░░░░░
}

error: the evaluated program leaked memory

note: pass `-Zmiri-ignore-leaks` to disable this check

error: aborting due to previous error

• CI which is failing

[TimDiekmann]

I was able to track down the bug further. The bug happened after #44 was merged.

[Amanieu]

Can you get a backtrace of where the leak came from? It's not obvious to me what is causing this.

[Amanieu]

Nevermind, I found the problem and yanked 1.1.5.

[terrarier2111]

Will there be a new release including a patch for this issue?

[Amanieu]

Fixed in 1.1.6.

[TimDiekmann]

Thanks for the quick actions!