Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Swagger-spec.yaml to Open-api.yaml #1745

Open
wants to merge 2 commits into
base: release/11.0.0-next
Choose a base branch
from

Conversation

kpanot
Copy link
Contributor

@kpanot kpanot commented May 2, 2024

Depending to #1744

@kpanot kpanot requested a review from a team as a code owner May 2, 2024 11:56
Copy link

nx-cloud bot commented May 2, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f3f6112. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx run-many --target=test-e2e --parallel 3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

```

> [!NOTE]
> The parameters `--from` is mandatory to provide the version of the `@ama-sdk/schematics` package original from which the rules should be run.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
> The parameters `--from` is mandatory to provide the version of the `@ama-sdk/schematics` package original from which the rules should be run.
> The `--from` parameter is mandatory to provide the version of the original `@ama-sdk/schematics` package from which the rules should be run.

"properties": {
"from": {
"type": "string",
"description": "Starting version from which executing the migration scripts",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "Starting version from which executing the migration scripts",
"description": "Starting version from which the migration scripts are executed",

@@ -0,0 +1,7 @@
/** Schematic Option */
export interface MigrateSchematicsSchemaOptions {
/** Starting version from which executing the migration scripts */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/** Starting version from which executing the migration scripts */
/** Starting version from which the migration scripts are executed */

@@ -0,0 +1,7 @@
/** Schematic Option */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
/** Schematic Option */
/** Migrate Schematics Options */

};

/**
* Generate a Extension of a API core definition
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Generate a Extension of a API core definition
* Generate an Extension of an API core definition

}

/**
* Generate a Extension of a API core definition
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Generate a Extension of a API core definition
* Generate an Extension of an API core definition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants