fix(schematic-sdk): to support the multi tag API #1739
+12
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdo-1A
reviewed
May 2, 2024
...pescript/core/openapi-codegen-typescript/src/main/resources/typescriptFetch/api/api.mustache
Outdated
Show resolved
Hide resolved
mrednic-1A
reviewed
May 2, 2024
| */ | ||
| export interface {{#uppercaseFirst}}{{nickname}}{{/uppercaseFirst}} extends {{#uppercaseFirst}}{{nickname}}{{/uppercaseFirst}}RequestData {} | ||
| /** @deprecated please use {{classname}}{{#uppercaseFirst}}{{nickname}}{{/uppercaseFirst}}RequestData instead, will be remove in Otter v12 */ | ||
| export interface {{#uppercaseFirst}}{{nickname}}{{/uppercaseFirst}}RequestData extends {{classname}}{{#uppercaseFirst}}{{nickname}}{{/uppercaseFirst}}RequestData {} |
There was a problem hiding this comment.
even if the interface is deprecated it is still exported, and I am afraid that we will still have duplications on the barrel file, no ?
{{#uppercaseFirst}}{{nickname}}{{/uppercaseFirst}}RequestData from one my.api.ts file and the same maybe from another file your.api.ts
There was a problem hiding this comment.
Yes, unfortunately the multi tag support cannot be achieved without breaking change (as we cannot really removed an interfaced exported already).
So this PR is an enabler but the support will be effective only after breaking change.
[Bug]: Multi tagged APIs not supported #855
kpanot
force-pushed
the
bugfix/multi-tag-support
branch
from
114a3cc
to
7df34aa
Compare
cpaulve-1A
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add the support of multi Api Tag via the duplication of the Api Class.
Related issues