feat: ng-update script for migration to openapitools 7.4 #1696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 68e38ec. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
github-actions
bot
added
enhancement
packages/@ama-sdk/schematics/schematics/ng-update/typescript/v10.3/update-openapiversion.ts
Outdated
Show resolved
Hide resolved
packages/@ama-sdk/schematics/schematics/ng-update/typescript/v10.3/update-openapiversion.ts
Outdated
Show resolved
Hide resolved
packages/@ama-sdk/schematics/schematics/ng-update/typescript/v10.3/update-openapiversion.ts
Outdated
Show resolved
Hide resolved
packages/@ama-sdk/schematics/schematics/ng-update/typescript/v10.3/update-openapiversion.ts
Outdated
Show resolved
Hide resolved
kpanot
reviewed
Apr 22, 2024
packages/@ama-sdk/schematics/schematics/ng-update/typescript/v10.3/update-openapiversion.ts
Outdated
Show resolved
Hide resolved
cpaulve-1A
force-pushed
the
fix/openapi-version-override
branch
2 times, most recently
from
bb7c9ef
to
8608aca
Compare
kpanot
reviewed
Apr 24, 2024
packages/@ama-sdk/schematics/schematics/ng-update/typescript/v10.3/update-openapiversion.ts
Show resolved
Hide resolved
kpanot
reviewed
Apr 24, 2024
sdo-1A
previously approved these changes
May 24, 2024
cpaulve-1A
force-pushed
the
fix/openapi-version-override
branch
from
8608aca
to
d4faf62
Compare
kpanot
approved these changes
May 29, 2024
| /** | ||
| * Facilitate the migration of a version to another by the run of migration rules | ||
| * @param options | ||
| */ | ||
| function migrateFn(options: MigrateSchematicsSchemaOptions): Rule { | ||
|
|
||
| const currentVersion = JSON.parse(require(resolve(__dirname, '..', '..', 'package.json'))).version; | ||
| const currentVersion = require(resolve(__dirname, '..', '..', 'package.json')).version; |
vscaiceanu-1a
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Ng update script to help the migration to @ama-sdk/schematics 10.3
As projects generated via the @ama-sdk/create command, the update is exposed as a schematics.
Unfortunately, it will not allow the update of several version in one command and needs the 10.3 version of ama-sdk/schematics to already be installed to be run.