feat(components): expose the placeholder service in @o3r/components #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpanot
force-pushed
the
feature/placeholder-expose-service
branch
from
232ea58
to
151f16a
Compare
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a3105cc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
github-actions
bot
added
enhancement
kpanot
force-pushed
the
feature/placeholder-expose-service
branch
3 times, most recently
from
30d0655
to
b47b02c
Compare
sdo-1A
reviewed
Apr 16, 2024
packages/@o3r/components/src/tools/placeholder/placeholder.interface.ts
Outdated
Show resolved
Hide resolved
mrednic-1A
reviewed
Apr 18, 2024
mrednic-1A
reviewed
Apr 18, 2024
packages/@o3r/components/src/stores/placeholder-effect/placeholder.effect.ts
Outdated
Show resolved
Hide resolved
kpanot
force-pushed
the
feature/placeholder-expose-service
branch
3 times, most recently
from
e1c30a4
to
ce47122
Compare
kpanot
force-pushed
the
feature/placeholder-expose-service
branch
from
ce47122
to
f44d554
Compare
kpanot
force-pushed
the
feature/placeholder-expose-service
branch
2 times, most recently
from
42d8a98
to
32a5ea7
Compare
…ed without rule-engine
kpanot
force-pushed
the
feature/placeholder-expose-service
branch
from
32a5ea7
to
a3105cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Expose the service to provide Placeholder Template URLs in the
@o3r/componentspackage instead on the rules engine.The next (followed by #1617) is let the Effect also accessible via
@o3r/componentsRelated issues