feat: migration schematics #1744
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 0b8cdda. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
github-actions
bot
added
enhancement
kpanot
force-pushed
the
feature/migrate-schematics
branch
from
6a9b544
to
04e59a3
Compare
| }; | ||
|
|
||
| const isTypescriptSdk = (tree: Tree) => { | ||
| return tree.exists('/tsconfig.json'); |
There was a problem hiding this comment.
This is not enough for applications with tsconfig files following the tsconfig.bas.json pattern (you can have a look at #1696)
There was a problem hiding this comment.
You should always have a tsconfig.json in anycase, if there is no tsconfig.json in a project based on Typescript it is maybe an issue. But not always at the root (in case of monorepo) indeed.
I fixed the code by checking pattern and allowing additional path. I moved it to be shared between the 2 schematics
kpanot
force-pushed
the
feature/migrate-schematics
branch
from
04e59a3
to
a43848a
Compare
Proposed change
Provide migration schematics to manually apply migration
Related issues