Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes validation message formatting/styling and adds smaller changes to useLanguage hook #2098

Merged
merged 2 commits into from
May 16, 2024

Conversation

cammiida
Copy link
Contributor

Description

Fikses some styling issues when validation messages are too long. Also did a minor refactoring of useLanguage.ts to make it a tiny bit more readable (at least for me πŸ’β€β™€οΈ).

Would love feedback on both the refactoring and the fix.

image

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@cammiida cammiida force-pushed the fix/validation-message-formatting branch from b0ae5ab to 798efa8 Compare May 16, 2024 11:40
Copy link
Contributor

@olemartinorg olemartinorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup looks good! πŸš€ πŸ₯³

@olemartinorg
Copy link
Contributor

Oooh, this percy screenshot may have identified a breaking change in the language cleanup! πŸ€”

Copy link

sonarcloud bot commented May 16, 2024

@cammiida cammiida merged commit 7489f30 into main May 16, 2024
8 of 9 checks passed
@cammiida cammiida deleted the fix/validation-message-formatting branch May 16, 2024 16:05
@olemartinorg olemartinorg added the kind/bug Something isn't working label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validation message formatting/layout when using the Address component is not good
2 participants