Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display name instead of paymentId in name field, and format expiration date #2094

Merged
merged 3 commits into from
May 22, 2024

Conversation

Magnusrm
Copy link
Contributor

@Magnusrm Magnusrm commented May 15, 2024

Description

It was noticed we did not display the correct data in for the payer name in the receipt.

This PR fixes that issue and also formats the expirationdate of the card displayed in the receipt.

Result:
image

Related Issue(s)

  • closes #{issue number}

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@Magnusrm Magnusrm self-assigned this May 15, 2024
@Magnusrm Magnusrm added the kind/bug Something isn't working label May 15, 2024
@Magnusrm Magnusrm requested a review from adamhaeger May 15, 2024 15:05
Copy link

sonarcloud bot commented May 22, 2024

@Magnusrm Magnusrm merged commit 5d64b86 into main May 22, 2024
9 checks passed
@Magnusrm Magnusrm deleted the fix/payment-receipt-name-and-expiration-date branch May 22, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
Status: 🧪 Test
Development

Successfully merging this pull request may close these issues.

None yet

1 participant